-
Notifications
You must be signed in to change notification settings - Fork 323
Cleanup duplicate Exception throws. #10327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup duplicate Exception throws. #10327
Conversation
sarahchen6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~8965065bb4, baseline=1.59.0-SNAPSHOT~61273bcf0b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.097 s) : 0, 1096954
Total [baseline] (10.875 s) : 0, 10874560
Agent [candidate] (1.095 s) : 0, 1095266
Total [candidate] (10.807 s) : 0, 10806627
section appsec
Agent [baseline] (1.267 s) : 0, 1267242
Total [baseline] (10.86 s) : 0, 10860444
Agent [candidate] (1.267 s) : 0, 1267215
Total [candidate] (10.868 s) : 0, 10867793
section iast
Agent [baseline] (1.225 s) : 0, 1224591
Total [baseline] (11.189 s) : 0, 11188822
Agent [candidate] (1.222 s) : 0, 1221901
Total [candidate] (11.13 s) : 0, 11130400
section profiling
Agent [baseline] (1.205 s) : 0, 1204834
Total [baseline] (10.926 s) : 0, 10925701
Agent [candidate] (1.203 s) : 0, 1202749
Total [candidate] (10.911 s) : 0, 10911280
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~8965065bb4, baseline=1.59.0-SNAPSHOT~61273bcf0b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (658.812 ms) : 0, 658812
BytebuddyAgent [candidate] (658.405 ms) : 0, 658405
GlobalTracer [baseline] (285.811 ms) : 0, 285811
GlobalTracer [candidate] (285.334 ms) : 0, 285334
AppSec [baseline] (33.094 ms) : 0, 33094
AppSec [candidate] (33.05 ms) : 0, 33050
Debugger [baseline] (68.865 ms) : 0, 68865
Debugger [candidate] (68.315 ms) : 0, 68315
Remote Config [baseline] (616.978 µs) : 0, 617
Remote Config [candidate] (609.455 µs) : 0, 609
Telemetry [baseline] (9.117 ms) : 0, 9117
Telemetry [candidate] (9.014 ms) : 0, 9014
Flare Poller [baseline] (3.836 ms) : 0, 3836
Flare Poller [candidate] (3.738 ms) : 0, 3738
section appsec
crashtracking [baseline] (1.171 ms) : 0, 1171
crashtracking [candidate] (1.168 ms) : 0, 1168
BytebuddyAgent [baseline] (691.254 ms) : 0, 691254
BytebuddyAgent [candidate] (691.924 ms) : 0, 691924
GlobalTracer [baseline] (259.474 ms) : 0, 259474
GlobalTracer [candidate] (258.593 ms) : 0, 258593
IAST [baseline] (24.832 ms) : 0, 24832
IAST [candidate] (24.569 ms) : 0, 24569
AppSec [baseline] (173.457 ms) : 0, 173457
AppSec [candidate] (173.658 ms) : 0, 173658
Debugger [baseline] (67.903 ms) : 0, 67903
Debugger [candidate] (67.975 ms) : 0, 67975
Remote Config [baseline] (762.093 µs) : 0, 762
Remote Config [candidate] (773.451 µs) : 0, 773
Telemetry [baseline] (9.276 ms) : 0, 9276
Telemetry [candidate] (9.428 ms) : 0, 9428
Flare Poller [baseline] (3.806 ms) : 0, 3806
Flare Poller [candidate] (3.764 ms) : 0, 3764
section iast
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.173 ms) : 0, 1173
BytebuddyAgent [baseline] (791.582 ms) : 0, 791582
BytebuddyAgent [candidate] (790.078 ms) : 0, 790078
GlobalTracer [baseline] (256.479 ms) : 0, 256479
GlobalTracer [candidate] (255.531 ms) : 0, 255531
IAST [baseline] (26.97 ms) : 0, 26970
IAST [candidate] (27.18 ms) : 0, 27180
AppSec [baseline] (34.497 ms) : 0, 34497
AppSec [candidate] (33.526 ms) : 0, 33526
Debugger [baseline] (65.825 ms) : 0, 65825
Debugger [candidate] (66.593 ms) : 0, 66593
Remote Config [baseline] (561.994 µs) : 0, 562
Remote Config [candidate] (581.463 µs) : 0, 581
Telemetry [baseline] (8.504 ms) : 0, 8504
Telemetry [candidate] (8.436 ms) : 0, 8436
Flare Poller [baseline] (3.565 ms) : 0, 3565
Flare Poller [candidate] (3.546 ms) : 0, 3546
section profiling
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (703.373 ms) : 0, 703373
BytebuddyAgent [candidate] (702.143 ms) : 0, 702143
GlobalTracer [baseline] (220.865 ms) : 0, 220865
GlobalTracer [candidate] (220.415 ms) : 0, 220415
AppSec [baseline] (32.222 ms) : 0, 32222
AppSec [candidate] (32.106 ms) : 0, 32106
Debugger [baseline] (67.728 ms) : 0, 67728
Debugger [candidate] (67.426 ms) : 0, 67426
Remote Config [baseline] (601.295 µs) : 0, 601
Remote Config [candidate] (625.036 µs) : 0, 625
Telemetry [baseline] (8.735 ms) : 0, 8735
Telemetry [candidate] (8.767 ms) : 0, 8767
Flare Poller [baseline] (3.659 ms) : 0, 3659
Flare Poller [candidate] (3.651 ms) : 0, 3651
ProfilingAgent [baseline] (96.625 ms) : 0, 96625
ProfilingAgent [candidate] (96.651 ms) : 0, 96651
Profiling [baseline] (97.198 ms) : 0, 97198
Profiling [candidate] (97.22 ms) : 0, 97220
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~8965065bb4, baseline=1.59.0-SNAPSHOT~61273bcf0b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.098 s) : 0, 1098418
Total [baseline] (8.809 s) : 0, 8809045
Agent [candidate] (1.084 s) : 0, 1083511
Total [candidate] (8.726 s) : 0, 8726418
section iast
Agent [baseline] (1.242 s) : 0, 1242032
Total [baseline] (9.414 s) : 0, 9414453
Agent [candidate] (1.222 s) : 0, 1222096
Total [candidate] (9.298 s) : 0, 9297682
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~8965065bb4, baseline=1.59.0-SNAPSHOT~61273bcf0b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (660.731 ms) : 0, 660731
BytebuddyAgent [candidate] (651.042 ms) : 0, 651042
GlobalTracer [baseline] (285.868 ms) : 0, 285868
GlobalTracer [candidate] (282.636 ms) : 0, 282636
AppSec [baseline] (33.167 ms) : 0, 33167
AppSec [candidate] (32.564 ms) : 0, 32564
Debugger [baseline] (68.088 ms) : 0, 68088
Debugger [candidate] (67.355 ms) : 0, 67355
Remote Config [baseline] (627.65 µs) : 0, 628
Remote Config [candidate] (616.677 µs) : 0, 617
Telemetry [baseline] (9.08 ms) : 0, 9080
Telemetry [candidate] (8.949 ms) : 0, 8949
Flare Poller [baseline] (3.891 ms) : 0, 3891
Flare Poller [candidate] (3.724 ms) : 0, 3724
section iast
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.173 ms) : 0, 1173
BytebuddyAgent [baseline] (806.252 ms) : 0, 806252
BytebuddyAgent [candidate] (790.978 ms) : 0, 790978
GlobalTracer [baseline] (258.991 ms) : 0, 258991
GlobalTracer [candidate] (255.754 ms) : 0, 255754
IAST [baseline] (27.485 ms) : 0, 27485
IAST [candidate] (26.946 ms) : 0, 26946
AppSec [baseline] (31.349 ms) : 0, 31349
AppSec [candidate] (34.246 ms) : 0, 34246
Debugger [baseline] (68.271 ms) : 0, 68271
Debugger [candidate] (64.996 ms) : 0, 64996
Remote Config [baseline] (595.134 µs) : 0, 595
Remote Config [candidate] (560.147 µs) : 0, 560
Telemetry [baseline] (8.557 ms) : 0, 8557
Telemetry [candidate] (8.554 ms) : 0, 8554
Flare Poller [baseline] (3.537 ms) : 0, 3537
Flare Poller [candidate] (3.59 ms) : 0, 3590
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 4 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~8965065bb4, baseline=1.59.0-SNAPSHOT~61273bcf0b
dateFormat X
axisFormat %s
section baseline
no_agent (19.423 ms) : 19218, 19629
. : milestone, 19423,
appsec (19.112 ms) : 18916, 19309
. : milestone, 19112,
code_origins (18.356 ms) : 18170, 18542
. : milestone, 18356,
iast (18.217 ms) : 18035, 18398
. : milestone, 18217,
profiling (19.568 ms) : 19371, 19764
. : milestone, 19568,
tracing (18.442 ms) : 18258, 18627
. : milestone, 18442,
section candidate
no_agent (19.805 ms) : 19602, 20009
. : milestone, 19805,
appsec (19.03 ms) : 18838, 19221
. : milestone, 19030,
code_origins (18.258 ms) : 18075, 18442
. : milestone, 18258,
iast (19.14 ms) : 18945, 19334
. : milestone, 19140,
profiling (21.082 ms) : 20860, 21305
. : milestone, 21082,
tracing (18.156 ms) : 17975, 18337
. : milestone, 18156,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~8965065bb4, baseline=1.59.0-SNAPSHOT~61273bcf0b
dateFormat X
axisFormat %s
section baseline
no_agent (1.291 ms) : 1279, 1304
. : milestone, 1291,
iast (3.458 ms) : 3407, 3510
. : milestone, 3458,
iast_FULL (5.986 ms) : 5925, 6046
. : milestone, 5986,
iast_GLOBAL (3.659 ms) : 3598, 3721
. : milestone, 3659,
profiling (2.284 ms) : 2261, 2307
. : milestone, 2284,
tracing (2.01 ms) : 1992, 2028
. : milestone, 2010,
section candidate
no_agent (1.287 ms) : 1275, 1299
. : milestone, 1287,
iast (3.403 ms) : 3350, 3456
. : milestone, 3403,
iast_FULL (6.161 ms) : 6097, 6225
. : milestone, 6161,
iast_GLOBAL (3.754 ms) : 3684, 3823
. : milestone, 3754,
profiling (2.297 ms) : 2275, 2318
. : milestone, 2297,
tracing (1.939 ms) : 1924, 1955
. : milestone, 1939,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~8965065bb4, baseline=1.59.0-SNAPSHOT~61273bcf0b
dateFormat X
axisFormat %s
section baseline
no_agent (1.487 ms) : 1476, 1499
. : milestone, 1487,
appsec (4.133 ms) : 3882, 4384
. : milestone, 4133,
iast (2.592 ms) : 2490, 2695
. : milestone, 2592,
iast_GLOBAL (2.634 ms) : 2530, 2737
. : milestone, 2634,
profiling (2.413 ms) : 2325, 2500
. : milestone, 2413,
tracing (2.391 ms) : 2306, 2476
. : milestone, 2391,
section candidate
no_agent (1.485 ms) : 1474, 1497
. : milestone, 1485,
appsec (4.228 ms) : 3972, 4485
. : milestone, 4228,
iast (2.592 ms) : 2490, 2695
. : milestone, 2592,
iast_GLOBAL (2.645 ms) : 2541, 2748
. : milestone, 2645,
profiling (2.449 ms) : 2360, 2538
. : milestone, 2449,
tracing (2.383 ms) : 2299, 2467
. : milestone, 2383,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~8965065bb4, baseline=1.59.0-SNAPSHOT~61273bcf0b
dateFormat X
axisFormat %s
section baseline
no_agent (15.067 s) : 15067000, 15067000
. : milestone, 15067000,
appsec (14.368 s) : 14368000, 14368000
. : milestone, 14368000,
iast (17.311 s) : 17311000, 17311000
. : milestone, 17311000,
iast_GLOBAL (17.062 s) : 17062000, 17062000
. : milestone, 17062000,
profiling (14.173 s) : 14173000, 14173000
. : milestone, 14173000,
tracing (14.022 s) : 14022000, 14022000
. : milestone, 14022000,
section candidate
no_agent (14.574 s) : 14574000, 14574000
. : milestone, 14574000,
appsec (14.651 s) : 14651000, 14651000
. : milestone, 14651000,
iast (17.51 s) : 17510000, 17510000
. : milestone, 17510000,
iast_GLOBAL (17.203 s) : 17203000, 17203000
. : milestone, 17203000,
profiling (14.591 s) : 14591000, 14591000
. : milestone, 14591000,
tracing (14.264 s) : 14264000, 14264000
. : milestone, 14264000,
|
What Does This Do
Cleanup duplicate condition check.
Motivation
Clean code.
Additional Notes
Found by IDEA static analysis.